address comments

apache · Oct 21, 2022 · 63d4a9c · 63d4a9c
1 parent cbb400c
commit 63d4a9c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 18 deletions.
diff --git a/tests/integration_tests/access_tests.py b/tests/integration_tests/access_tests.py
@@ -161,25 +161,25 @@ def test_override_role_permissions_1_table(self):
         with database.get_sqla_engine_with_context() as engine:
             schema = inspect(engine).default_schema_name
 
-            perm_data = ROLE_TABLES_PERM_DATA.copy()
-            perm_data["database"][0]["schema"][0]["name"] = schema
+        perm_data = ROLE_TABLES_PERM_DATA.copy()
+        perm_data["database"][0]["schema"][0]["name"] = schema
 
-            response = self.client.post(
-                "/superset/override_role_permissions/",
-                data=json.dumps(perm_data),
-                content_type="application/json",
-            )
-            self.assertEqual(201, response.status_code)
+        response = self.client.post(
+            "/superset/override_role_permissions/",
+            data=json.dumps(perm_data),
+            content_type="application/json",
+        )
+        self.assertEqual(201, response.status_code)
 
-            updated_override_me = security_manager.find_role("override_me")
-            self.assertEqual(1, len(updated_override_me.permissions))
-            birth_names = self.get_table(name="birth_names")
-            self.assertEqual(
-                birth_names.perm, updated_override_me.permissions[0].view_menu.name
-            )
-            self.assertEqual(
-                "datasource_access", updated_override_me.permissions[0].permission.name
-            )
+        updated_override_me = security_manager.find_role("override_me")
+        self.assertEqual(1, len(updated_override_me.permissions))
+        birth_names = self.get_table(name="birth_names")
+        self.assertEqual(
+            birth_names.perm, updated_override_me.permissions[0].view_menu.name
+        )
+        self.assertEqual(
+            "datasource_access", updated_override_me.permissions[0].permission.name
+        )
 
     @pytest.mark.usefixtures(
         "load_energy_table_with_slice", "load_birth_names_dashboard_with_slices"

diff --git a/tests/integration_tests/reports/commands_tests.py b/tests/integration_tests/reports/commands_tests.py
@@ -136,7 +136,8 @@ def create_test_table_context(database: Database):
         engine.execute("INSERT INTO test_table (first, second) VALUES (3, 4)")
 
     yield db.session
-    database.get_sqla_engine().execute("DROP TABLE test_table")
+    with database.get_sqla_engine_with_context() as engine:
+        engine.execute("DROP TABLE test_table")
 
 
 @pytest.fixture()