-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Adds tests to the OptionControls component (#13729)
- Loading branch information
1 parent
ec5d2f5
commit 6fd62e3
Showing
12 changed files
with
156 additions
and
82 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 0 additions & 69 deletions
69
superset-frontend/spec/javascripts/explore/components/OptionControls_spec.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 143 additions & 0 deletions
143
superset-frontend/src/explore/components/controls/OptionControls/OptionControls.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
import React from 'react'; | ||
import { render, screen, fireEvent } from 'spec/helpers/testing-library'; | ||
import { DndProvider } from 'react-dnd'; | ||
import { HTML5Backend } from 'react-dnd-html5-backend'; | ||
import { | ||
OptionControlLabel, | ||
DragContainer, | ||
OptionControlContainer, | ||
Label, | ||
CaretContainer, | ||
CloseContainer, | ||
HeaderContainer, | ||
LabelsContainer, | ||
DndLabelsContainer, | ||
AddControlLabel, | ||
AddIconButton, | ||
} from 'src/explore/components/controls/OptionControls'; | ||
|
||
const defaultProps = { | ||
label: <span>Test label</span>, | ||
onRemove: jest.fn(), | ||
onMoveLabel: jest.fn(), | ||
onDropLabel: jest.fn(), | ||
type: 'test', | ||
index: 0, | ||
}; | ||
|
||
const setup = (overrides?: Record<string, any>) => | ||
render( | ||
<DndProvider backend={HTML5Backend}> | ||
<OptionControlLabel {...defaultProps} {...overrides} /> | ||
</DndProvider>, | ||
); | ||
|
||
test('should render', () => { | ||
const { container } = setup(); | ||
expect(container).toBeVisible(); | ||
}); | ||
|
||
test('should display a label', () => { | ||
setup(); | ||
expect(screen.getByText('Test label')).toBeTruthy(); | ||
}); | ||
|
||
test('should display a certification icon if saved metric is certified', () => { | ||
const { container } = setup({ | ||
savedMetric: { | ||
metric_name: 'test_metric', | ||
is_certified: true, | ||
}, | ||
}); | ||
screen.getByText('test_metric'); | ||
expect(screen.queryByText('Test label')).toBeFalsy(); | ||
expect(container.querySelector('.metric-option > svg')).toBeInTheDocument(); | ||
}); | ||
|
||
test('triggers onMoveLabel on drop', () => { | ||
render( | ||
<DndProvider backend={HTML5Backend}> | ||
<OptionControlLabel | ||
{...defaultProps} | ||
index={1} | ||
label={<span>Label 1</span>} | ||
/> | ||
<OptionControlLabel | ||
{...defaultProps} | ||
index={2} | ||
label={<span>Label 2</span>} | ||
/> | ||
</DndProvider>, | ||
); | ||
fireEvent.dragStart(screen.getByText('Label 1')); | ||
fireEvent.drop(screen.getByText('Label 2')); | ||
expect(defaultProps.onMoveLabel).toHaveBeenCalled(); | ||
}); | ||
|
||
test('renders DragContainer', () => { | ||
const { container } = render(<DragContainer />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders OptionControlContainer', () => { | ||
const { container } = render(<OptionControlContainer />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders Label', () => { | ||
const { container } = render(<Label />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders CaretContainer', () => { | ||
const { container } = render(<CaretContainer />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders CloseContainer', () => { | ||
const { container } = render(<CloseContainer />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders HeaderContainer', () => { | ||
const { container } = render(<HeaderContainer />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders LabelsContainer', () => { | ||
const { container } = render(<LabelsContainer />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders DndLabelsContainer', () => { | ||
const { container } = render(<DndLabelsContainer />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders AddControlLabel', () => { | ||
const { container } = render(<AddControlLabel />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
test('renders AddIconButton', () => { | ||
const { container } = render(<AddIconButton />); | ||
expect(container).toBeInTheDocument(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters