fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart * fix(dashboard):Hide reports modal for anonymous users * Address comments * Make prettier happy Co-authored-by: Mayur <mayurp@kpmg.com>
apache · Jan 10, 2022 · 70ebf0a · 70ebf0a
1 parent e4ce83a
commit 70ebf0a
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 5 deletions.
diff --git a/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx b/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
@@ -60,10 +60,8 @@ export default function HeaderReportActionsDropDown({
     any,
     UserWithPermissionsAndRoles
   >(state => state.user || state.explore?.user);
-  const [
-    currentReportDeleting,
-    setCurrentReportDeleting,
-  ] = useState<AlertObject | null>(null);
+  const [currentReportDeleting, setCurrentReportDeleting] =
+    useState<AlertObject | null>(null);
   const theme = useTheme();
   const [showModal, setShowModal] = useState<boolean>(false);
   const toggleActiveKey = async (data: AlertObject, checked: boolean) => {
@@ -81,7 +79,7 @@ export default function HeaderReportActionsDropDown({
     if (!isFeatureEnabled(FeatureFlag.ALERT_REPORTS)) {
       return false;
     }
-    if (!user) {
+    if (!user?.userId) {
       // this is in the case that there is an anonymous user.
       return false;
     }

diff --git a/superset-frontend/src/dashboard/components/Header/Header.test.tsx b/superset-frontend/src/dashboard/components/Header/Header.test.tsx
@@ -465,4 +465,31 @@ describe('Email Report Modal', () => {
     // BLOCKER: I cannot get report to populate, as its data is handled through redux
     expect.anything();
   });
+
+  it('Should render report header', async () => {
+    const mockedProps = createProps();
+    render(setup(mockedProps));
+    expect(
+      screen.getByRole('button', { name: 'Schedule email report' }),
+    ).toBeInTheDocument();
+  });
+
+  it('Should not render report header even with menu access for anonymous user', async () => {
+    const mockedProps = createProps();
+    const anonymousUserProps = {
+      ...mockedProps,
+      user: {
+        roles: {
+          Public: [['menu_access', 'Manage']],
+        },
+        permissions: {
+          datasource_access: ['[examples].[birth_names](id:2)'],
+        },
+      },
+    };
+    render(setup(anonymousUserProps));
+    expect(
+      screen.queryByRole('button', { name: 'Schedule email report' }),
+    ).not.toBeInTheDocument();
+  });
 });