add exc

apache · Jan 12, 2023 · 71cb19a · 71cb19a
1 parent 94b711d
commit 71cb19a
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/superset/databases/commands/test_connection.py b/superset/databases/commands/test_connection.py
@@ -165,7 +165,9 @@ def ping(engine: Engine) -> bool:
 
         except (NoSuchModuleError, ModuleNotFoundError) as ex:
             event_logger.log_with_context(
-                action=get_log_connection_action("test_connection_error", ssh_tunnel),
+                action=get_log_connection_action(
+                    "test_connection_error", ssh_tunnel, ex
+                ),
                 engine=database.db_engine_spec.__name__,
             )
             raise DatabaseTestConnectionDriverError(
@@ -175,29 +177,37 @@ def ping(engine: Engine) -> bool:
             ) from ex
         except DBAPIError as ex:
             event_logger.log_with_context(
-                action=get_log_connection_action("test_connection_error", ssh_tunnel),
+                action=get_log_connection_action(
+                    "test_connection_error", ssh_tunnel, ex
+                ),
                 engine=database.db_engine_spec.__name__,
             )
             # check for custom errors (wrong username, wrong password, etc)
             errors = database.db_engine_spec.extract_errors(ex, context)
             raise SupersetErrorsException(errors) from ex
         except SupersetSecurityException as ex:
             event_logger.log_with_context(
-                action=get_log_connection_action("test_connection_error", ssh_tunnel),
+                action=get_log_connection_action(
+                    "test_connection_error", ssh_tunnel, ex
+                ),
                 engine=database.db_engine_spec.__name__,
             )
             raise DatabaseSecurityUnsafeError(message=str(ex)) from ex
         except SupersetTimeoutException as ex:
 
             event_logger.log_with_context(
-                action=get_log_connection_action("test_connection_error", ssh_tunnel),
+                action=get_log_connection_action(
+                    "test_connection_error", ssh_tunnel, ex
+                ),
                 engine=database.db_engine_spec.__name__,
             )
             # bubble up the exception to return a 408
             raise ex
         except Exception as ex:
             event_logger.log_with_context(
-                action=get_log_connection_action("test_connection_error", ssh_tunnel),
+                action=get_log_connection_action(
+                    "test_connection_error", ssh_tunnel, ex
+                ),
                 engine=database.db_engine_spec.__name__,
             )
             errors = database.db_engine_spec.extract_errors(ex, context)