[hotfix] Table view doesn't allow SELECT (no group by) (#2274)

apache · Feb 26, 2017 · 7339392 · 7339392
1 parent f9852bc
commit 7339392
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/superset/assets/javascripts/explorev2/stores/visTypes.js b/superset/assets/javascripts/explorev2/stores/visTypes.js
@@ -254,6 +254,12 @@ const visTypes = {
         ],
       },
     ],
+    controlOverrides: {
+      metrics: {
+        default: null,
+        validators: null,
+      },
+    },
   },
 
   markup: {

diff --git a/superset/assets/visualizations/table.js b/superset/assets/visualizations/table.js
@@ -19,9 +19,11 @@ function tableVis(slice, payload) {
   const fd = slice.formData;
   // Removing metrics (aggregates) that are strings
   const realMetrics = [];
-  for (const k in data.records[0]) {
-    if (fd.metrics.indexOf(k) > -1 && !isNaN(data.records[0][k])) {
-      realMetrics.push(k);
+  if (fd.metrics) {
+    for (const k in data.records[0]) {
+      if (fd.metrics.indexOf(k) > -1 && !isNaN(data.records[0][k])) {
+        realMetrics.push(k);
+      }
     }
   }
   const metrics = realMetrics;