feat(chart & legend): make to enable show legend by default (#19927)

apache · May 2, 2022 · 7b3d0f0 · 7b3d0f0
1 parent 8b6e582
commit 7b3d0f0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.ts
@@ -274,7 +274,7 @@ const config: ControlPanelConfig = {
               type: 'CheckboxControl',
               label: t('Legend'),
               renderTrigger: true,
-              default: false,
+              default: true,
               description: t('Whether to display the legend (toggles)'),
             },
           },

diff --git a/superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts
@@ -128,7 +128,7 @@ const config: ControlPanelConfig = {
               type: 'CheckboxControl',
               label: t('Legend'),
               renderTrigger: true,
-              default: false,
+              default: true,
               description: t('Whether to display the legend (toggles)'),
             },
           },

diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx
@@ -148,7 +148,7 @@ export const showLegend: CustomControlItem = {
     type: 'CheckboxControl',
     label: t('Legend'),
     renderTrigger: true,
-    default: false,
+    default: true,
     description: t('Whether to display the legend (toggles)'),
   },
 };

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/types.ts b/superset-frontend/plugins/plugin-chart-echarts/src/types.ts
@@ -87,7 +87,7 @@ export const DEFAULT_LEGEND_FORM_DATA: EchartsLegendFormData = {
   legendMargin: null,
   legendOrientation: LegendOrientation.Top,
   legendType: LegendType.Scroll,
-  showLegend: false,
+  showLegend: true,
 };
 
 export type EventHandlers = Record<string, { (props: any): void }>;