Refetch samples only when filters change (#11999)

apache · Jan 2, 2021 · 7cc0de1 · 7cc0de1
1 parent f3ab1f4
commit 7cc0de1
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/superset-frontend/src/explore/components/DataTablesPane.tsx b/superset-frontend/src/explore/components/DataTablesPane.tsx
@@ -138,12 +138,19 @@ export const DataTablesPane = ({
   );
 
   useEffect(() => {
-    setIsRequestPending({
+    setIsRequestPending(prevState => ({
+      ...prevState,
       [RESULT_TYPES.results]: true,
-      [RESULT_TYPES.samples]: true,
-    });
+    }));
   }, [queryFormData]);
 
+  useEffect(() => {
+    setIsRequestPending(prevState => ({
+      ...prevState,
+      [RESULT_TYPES.samples]: true,
+    }));
+  }, [queryFormData.adhoc_filters]);
+
   useEffect(() => {
     if (panelOpen && isRequestPending[RESULT_TYPES.results]) {
       setIsRequestPending(prevState => ({