add error handling on create

apache · Dec 16, 2020 · 83206ed · 83206ed
1 parent 1806db7
commit 83206ed
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
@@ -578,8 +578,8 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
         delete data.last_value;
         delete data.last_value_row_json;
 
-        updateResource(update_id, data).then(result => {
-          if (!result) {
+        updateResource(update_id, data).then(response => {
+          if (!response) {
             return;
           }
 
@@ -593,6 +593,10 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
     } else if (currentAlert) {
       // Create
       createResource(data).then(response => {
+        if (!response) {
+          return;
+        }
+
         if (onAdd) {
           onAdd(response);
         }