fix: false negative on critical security related to eslint-plugin-tra…

…nslation-vars (#32018)
apache · Feb 10, 2025 · 8d1fb9c · 8d1fb9c
1 parent f014932
commit 8d1fb9c
Show file tree

Hide file tree

Showing 9 changed files with 40 additions and 71 deletions.
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
@@ -74,7 +74,7 @@ module.exports = {
     'file-progress',
     'lodash',
     'theme-colors',
-    'translation-vars',
+    'i18n-strings',
     'react-prefer-function-component',
     'prettier',
   ],
@@ -284,15 +284,15 @@ module.exports = {
       ],
       rules: {
         'theme-colors/no-literal-colors': 0,
-        'translation-vars/no-template-vars': 0,
+        'i18n-strings/no-template-vars': 0,
         'no-restricted-imports': 0,
         'react/no-void-elements': 0,
       },
     },
   ],
   rules: {
     'theme-colors/no-literal-colors': 'error',
-    'translation-vars/no-template-vars': ['error', true],
+    'i18n-strings/no-template-vars': ['error', true],
     camelcase: [
       'error',
       {

diff --git a/...s/eslint-plugin-translation-vars/index.js → ...rules/eslint-plugin-i18n-strings/index.js b/...s/eslint-plugin-translation-vars/index.js → ...rules/eslint-plugin-i18n-strings/index.js
diff --git a/...translation-vars/no-template-vars.test.js → ...gin-i18n-strings/no-template-vars.test.js b/...translation-vars/no-template-vars.test.js → ...gin-i18n-strings/no-template-vars.test.js
diff --git a/...lint-plugin-translation-vars/package.json → ...s/eslint-plugin-i18n-strings/package.json b/...lint-plugin-translation-vars/package.json → ...s/eslint-plugin-i18n-strings/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "eslint-plugin-translation-vars",
+  "name": "eslint-plugin-i18n-strings",
   "version": "1.0.0",
   "description": "Warns about translation variables",
   "main": "index.js",

diff --git a/...ools/eslint-plugin-theme-colors/colors.js → ...ules/eslint-plugin-theme-colors/colors.js b/...ools/eslint-plugin-theme-colors/colors.js → ...ules/eslint-plugin-theme-colors/colors.js
diff --git a/...tools/eslint-plugin-theme-colors/index.js → ...rules/eslint-plugin-theme-colors/index.js b/...tools/eslint-plugin-theme-colors/index.js → ...rules/eslint-plugin-theme-colors/index.js
diff --git a/...s/eslint-plugin-theme-colors/package.json → ...s/eslint-plugin-theme-colors/package.json b/...s/eslint-plugin-theme-colors/package.json → ...s/eslint-plugin-theme-colors/package.json
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -139,6 +139,7 @@
     "dom-to-pdf": "^0.3.2",
     "echarts": "^5.6.0",
     "emotion-rgba": "0.0.12",
+    "eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
     "fast-glob": "^3.3.2",
     "fs-extra": "^11.2.0",
     "fuse.js": "^7.0.0",
@@ -321,8 +322,7 @@
     "eslint-plugin-react-prefer-function-component": "^3.3.0",
     "eslint-plugin-storybook": "^0.8.0",
     "eslint-plugin-testing-library": "^6.4.0",
-    "eslint-plugin-theme-colors": "file:tools/eslint-plugin-theme-colors",
-    "eslint-plugin-translation-vars": "file:tools/eslint-plugin-translation-vars",
+    "eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
     "exports-loader": "^5.0.0",
     "fetch-mock": "^7.7.3",
     "fork-ts-checker-webpack-plugin": "^9.0.2",