Skip to content

Commit

Permalink
fixing date/time filter keys (#3611)
Browse files Browse the repository at this point in the history
  • Loading branch information
Mogball authored and mistercrunch committed Oct 7, 2017
1 parent 6f1351f commit 912c6f6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion superset/assets/visualizations/filter_box.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,10 @@ class FilterBox extends React.Component {
// Add created options to filtersChoices, even though it doesn't exist,
// or these options will exist in query sql but invisible to end user.
for (const filterKey in this.state.selectedValues) {
if (!this.state.selectedValues.hasOwnProperty(filterKey)) {
if (
!this.state.selectedValues.hasOwnProperty(filterKey) ||
!(filterKey in this.props.filtersChoices)
) {
continue;
}
const existValues = this.props.filtersChoices[filterKey].map(f => f.id);
Expand Down

0 comments on commit 912c6f6

Please sign in to comment.