resolve comment

superset-frontend/src/views/CRUD/hooks.ts

@@ -450,7 +450,7 @@ export function useImportResource(
                   resourceLabel,
                   [
                     ...error.errors.map(payload => payload.message),
-                    'Please re-export your file and try importing again',
+                    t('Please re-export your file and try importing again'),
                   ].join('\n'),
                 ),
               );
@@ -467,7 +467,7 @@ export function useImportResource(
           updateState({ loading: false });
         });
     },
-    [handleErrorMsg, resourceLabel, resourceName],
+    [],
   );
 
   return { state, importResource };

superset-frontend/src/views/CRUD/utils.test.tsx

@@ -165,7 +165,7 @@ test('detects if the error message is terminal or if it requires uses interventi
   expect(isTerminal).toBe(false);
 });
 
-test('error message is terminal when the extra field not contains other keys excepting issue_codes', () => {
+test('error message is terminal when the "extra" field contains only the "issue_codes" key', () => {
   expect(hasTerminalValidation(terminalErrorsWithOnlyIssuesCode.errors)).toBe(
     true,
   );

superset-frontend/src/views/CRUD/utils.tsx

@@ -400,14 +400,14 @@ export const getAlreadyExists = (errors: Record<string, any>[]) =>
 
 export const hasTerminalValidation = (errors: Record<string, any>[]) =>
   errors.some(error => {
-    const not_issues_codes = Object.entries(error.extra).filter(
-      ([key, _]) => key !== 'issue_codes',
+    const noIssuesCodes = Object.entries(error.extra).filter(
+      ([key]) => key !== 'issue_codes',
     );
 
-    if (not_issues_codes.length === 0) return true;
+    if (noIssuesCodes.length === 0) return true;
 
-    return !not_issues_codes.every(
-      ([_, payload]) => isNeedsPassword(payload) || isAlreadyExists(payload),
+    return !noIssuesCodes.every(
+      ([, payload]) => isNeedsPassword(payload) || isAlreadyExists(payload),
     );
   });