chore: Feature flag for embedding charts (#20804)

* Add EMBEDDABLE_CHARTS feature flag * Pretty * Update test
apache · Jul 26, 2022 · a69f016 · a69f016
1 parent cb9ae38
commit a69f016
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 17 deletions.
diff --git a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
@@ -56,6 +56,7 @@ export enum FeatureFlag {
   GENERIC_CHART_AXES = 'GENERIC_CHART_AXES',
   USE_ANALAGOUS_COLORS = 'USE_ANALAGOUS_COLORS',
   DASHBOARD_EDIT_CHART_IN_NEW_TAB = 'DASHBOARD_EDIT_CHART_IN_NEW_TAB',
+  EMBEDDABLE_CHARTS = 'EMBEDDABLE_CHARTS',
 }
 export type ScheduleQueriesProps = {
   JSONSCHEMA: {

diff --git a/superset-frontend/src/explore/components/ExploreChartHeader/ExploreChartHeader.test.tsx b/superset-frontend/src/explore/components/ExploreChartHeader/ExploreChartHeader.test.tsx
@@ -25,12 +25,17 @@ import fetchMock from 'fetch-mock';
 import * as chartAction from 'src/components/Chart/chartAction';
 import * as downloadAsImage from 'src/utils/downloadAsImage';
 import * as exploreUtils from 'src/explore/exploreUtils';
+import { FeatureFlag } from '@superset-ui/core';
 import ExploreHeader from '.';
 
 const chartEndpoint = 'glob:*api/v1/chart/*';
 
 fetchMock.get(chartEndpoint, { json: 'foo' });
 
+window.featureFlags = {
+  [FeatureFlag.EMBEDDABLE_CHARTS]: true,
+};
+
 const createProps = () => ({
   chart: {
     id: 1,

diff --git a/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx b/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
@@ -29,6 +29,7 @@ import downloadAsImage from 'src/utils/downloadAsImage';
 import { getChartPermalink } from 'src/utils/urlUtils';
 import copyTextToClipboard from 'src/utils/copy';
 import HeaderReportDropDown from 'src/components/ReportModal/HeaderReportDropdown';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
 import ViewQueryModal from '../controls/ViewQueryModal';
 import EmbedCodeContent from '../EmbedCodeContent';
 
@@ -297,23 +298,25 @@ export const useExploreAdditionalActionsMenu = (
           <Menu.Item key={MENU_KEYS.SHARE_BY_EMAIL}>
             {t('Share chart by email')}
           </Menu.Item>
-          <Menu.Item key={MENU_KEYS.EMBED_CODE}>
-            <ModalTrigger
-              triggerNode={
-                <span data-test="embed-code-button">{t('Embed code')}</span>
-              }
-              modalTitle={t('Embed code')}
-              modalBody={
-                <EmbedCodeContent
-                  formData={latestQueryFormData}
-                  addDangerToast={addDangerToast}
-                />
-              }
-              maxWidth={`${theme.gridUnit * 100}px`}
-              destroyOnClose
-              responsive
-            />
-          </Menu.Item>
+          {isFeatureEnabled(FeatureFlag.EMBEDDABLE_CHARTS) ? (
+            <Menu.Item key={MENU_KEYS.EMBED_CODE}>
+              <ModalTrigger
+                triggerNode={
+                  <span data-test="embed-code-button">{t('Embed code')}</span>
+                }
+                modalTitle={t('Embed code')}
+                modalBody={
+                  <EmbedCodeContent
+                    formData={latestQueryFormData}
+                    addDangerToast={addDangerToast}
+                  />
+                }
+                maxWidth={`${theme.gridUnit * 100}px`}
+                destroyOnClose
+                responsive
+              />
+            </Menu.Item>
+          ) : null}
         </Menu.SubMenu>
         <Menu.Divider />
         {showReportSubMenu ? (

diff --git a/superset/config.py b/superset/config.py
@@ -436,6 +436,8 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
     # Enable caching per impersonation key (e.g username) in a datasource where user
     # impersonation is enabled
     "CACHE_IMPERSONATION": False,
+    # Enable sharing charts with embedding
+    "EMBEDDABLE_CHARTS": True,
 }
 
 # Feature flags may also be set via 'SUPERSET_FEATURE_' prefixed environment vars.