fix(sqla): apply sqla type on calculated columns

apache · Apr 8, 2021 · aa604a4 · aa604a4
1 parent 56dc74e
commit aa604a4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -224,12 +224,12 @@ def is_temporal(self) -> bool:
 
     def get_sqla_col(self, label: Optional[str] = None) -> Column:
         label = label or self.column_name
+        db_engine_spec = self.table.database.db_engine_spec
+        column_spec = db_engine_spec.get_column_spec(self.type)
+        type_ = column_spec.sqla_type if column_spec else None
         if self.expression:
-            col = literal_column(self.expression)
+            col = literal_column(self.expression, type_=type_)
         else:
-            db_engine_spec = self.table.database.db_engine_spec
-            column_spec = db_engine_spec.get_column_spec(self.type)
-            type_ = column_spec.sqla_type if column_spec else None
             col = column(self.column_name, type_=type_)
         col = self.table.make_sqla_column_compatible(col, label)
         return col