Fix display limit in sql lab (#5392)

* Fix display limit in sql lab * Add redundant variable from config.py * Fix test config * Change to SQL_MAX_ROW * Remove last remaining occurence of DISPLAY_SQL_MAX_ROW
apache · Jul 16, 2018 · bd47587 · bd47587
1 parent 2eeff2a
commit bd47587
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/superset/config.py b/superset/config.py
@@ -250,8 +250,7 @@
 MAPBOX_API_KEY = os.environ.get('MAPBOX_API_KEY', '')
 
 # Maximum number of rows returned in the SQL editor
-SQL_MAX_ROW = 1000000
-DISPLAY_SQL_MAX_ROW = 1000
+SQL_MAX_ROW = 1000
 
 # Maximum number of tables/views displayed in the dropdown window in SQL Lab.
 MAX_TABLE_NAMES = 3000

diff --git a/superset/views/core.py b/superset/views/core.py
@@ -2477,7 +2477,7 @@ def results(self, key):
                 '{}'.format(rejected_tables)))
 
         payload = utils.zlib_decompress_to_string(blob)
-        display_limit = app.config.get('DISPLAY_SQL_MAX_ROW', None)
+        display_limit = app.config.get('SQL_MAX_ROW', None)
         if display_limit:
             payload_json = json.loads(payload)
             payload_json['data'] = payload_json['data'][:display_limit]