address comment

apache · Jun 9, 2022 · be7b680 · be7b680
1 parent 806ac54
commit be7b680
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx b/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
@@ -224,14 +224,14 @@ export default class Chart extends React.Component {
   }
 
   getHeaderHeight() {
-    const marginBottom = parseInt(
-      getComputedStyle(this.headerRef).getPropertyValue('margin-bottom'),
-    );
-    return this.headerRef
-      ? this.headerRef.offsetHeight + Number.isNaN(marginBottom)
-        ? 0
-        : marginBottom
-      : DEFAULT_HEADER_HEIGHT;
+    if (this.headerRef) {
+      const computedStyle = getComputedStyle(this.headerRef).getPropertyValue(
+        'margin-bottom',
+      );
+      const marginBottom = parseInt(computedStyle, 10) || 0;
+      return this.headerRef.offsetHeight + marginBottom;
+    }
+    return DEFAULT_HEADER_HEIGHT;
   }
 
   setDescriptionRef(ref) {