Remove configs and add RTL modules as peers

apache · Apr 25, 2024 · c2025bb · c2025bb
1 parent 9a8c434
commit c2025bb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/superset-frontend/packages/superset-ui-core/package.json b/superset-frontend/packages/superset-ui-core/package.json
@@ -84,6 +84,11 @@
     "@emotion/cache": "^11.4.0",
     "@emotion/react": "^11.4.1",
     "@emotion/styled": "^11.3.0",
+    "@testing-library/dom": "^7.29.4",
+    "@testing-library/jest-dom": "^5.11.6",
+    "@testing-library/react": "^11.2.0",
+    "@testing-library/react-hooks": "^5.1.3",
+    "@testing-library/user-event": "^12.7.0",
     "@types/react": "*",
     "@types/react-loadable": "*",
     "@types/tinycolor2": "*",

diff --git a/...rset-frontend/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx b/...rset-frontend/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx
@@ -19,17 +19,20 @@
 
 import React from 'react';
 import { render, screen } from '@testing-library/react';
-import '@testing-library/jest-dom/extend-expect';
+import '@testing-library/jest-dom';
 import { ThemeProvider, supersetTheme } from '../../../src/style';
 import NoResultsComponent from '../../../src/chart/components/NoResultsComponent';
 
-test('renders the no results error', () => {
+const renderNoResultsComponent = () =>
   render(
     <ThemeProvider theme={supersetTheme}>
       <NoResultsComponent height="400" width="300" />
     </ThemeProvider>,
   );
 
+test('renders the no results error', () => {
+  renderNoResultsComponent();
+
   expect(screen.getByText(/No Results/)).toBeInTheDocument();
   expect(
     screen.getByText(