Remove the rest of isValidDatasourceType check

apache · Jun 8, 2022 · c567756 · c567756
1 parent 95e59c9
commit c567756
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts b/superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts
@@ -54,10 +54,4 @@ export const DEFAULT_METRICS = [
   },
 ];
 
-export const isValidDatasourceType = (datasource: DatasourceType) =>
-  datasource === DatasourceType.Dataset ||
-  datasource === DatasourceType.SlTable ||
-  datasource === DatasourceType.SavedQuery ||
-  datasource === DatasourceType.Query;
-
 export default {};
diff --git a/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx b/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
@@ -19,7 +19,7 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import { t, styled, withTheme, isValidDatasourceType } from '@superset-ui/core';
+import { t, styled, withTheme, DatasourceType } from '@superset-ui/core';
 import { getUrlParam } from 'src/utils/urlUtils';
 
 import { AntdDropdown } from 'src/components';
@@ -303,7 +303,7 @@ class DatasourceControl extends React.PureComponent {
           )}
           <AntdDropdown
             overlay={
-              isValidDatasourceType(datasource.type)
+              datasource.type === DatasourceType.Query
                 ? queryDatasourceMenu
                 : defaultDatasourceMenu
             }