Fix <Select> clearable (#7215)

closes #7213 related to #6722 (comment)
apache · Apr 3, 2019 · e767e4d · agrawaldevesh · Apr 9, 2019 · e767e4d
1 parent 8830d3f
commit e767e4d
Showing 1 changed file with 16 additions and 17 deletions.
diff --git a/superset/assets/src/explore/components/controls/SelectControl.jsx b/superset/assets/src/explore/components/controls/SelectControl.jsx
@@ -92,25 +92,24 @@ export default class SelectControl extends React.PureComponent {
 
   onChange(opt) {
     let optionValue = null;
-    if (!opt) {
-      return;
-    }
-    if (this.props.multi) {
-      optionValue = [];
-      for (const o of opt) {
-        if (o.meta === true) {
-          optionValue = this.getOptions(this.props)
-                            .filter(x => !x.meta)
-                            .map(x => x[this.props.valueKey]);
-          break;
-        } else {
-          optionValue.push(o[this.props.valueKey]);
+    if (opt) {
+      if (this.props.multi) {
+        optionValue = [];
+        for (const o of opt) {
+          if (o.meta === true) {
+            optionValue = this.getOptions(this.props)
+                              .filter(x => !x.meta)
+                              .map(x => x[this.props.valueKey]);
+            break;
+          } else {
+            optionValue.push(o[this.props.valueKey]);
+          }
         }
+      } else if (opt.meta === true) {
+        return;
+      } else {
+        optionValue = opt[this.props.valueKey];
       }
-    } else if (opt.meta === true) {
-      return;
-    } else {
-      optionValue = opt[this.props.valueKey];
     }
     this.props.onChange(optionValue);
   }