remove console log

apache · Jun 21, 2023 · f4fb07b · f4fb07b
1 parent 97cddfe
commit f4fb07b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/superset-frontend/src/features/databases/DatabaseModal/index.tsx b/superset-frontend/src/features/databases/DatabaseModal/index.tsx
@@ -764,7 +764,6 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
       }
 
       // only do validation for non ssh tunnel connections
-      console.log(dbToUpdate);
       if (!dbToUpdate?.ssh_tunnel) {
         // make sure that button spinner animates
         setLoading(true);

diff --git a/superset-frontend/src/types/Database.ts b/superset-frontend/src/types/Database.ts
@@ -27,5 +27,4 @@ export default interface Database {
   server_cert: string;
   sqlalchemy_uri: string;
   catalog: object;
-  ssh_tunnel: object;
 }
diff --git a/superset-frontend/src/views/CRUD/hooks.ts b/superset-frontend/src/views/CRUD/hooks.ts
@@ -35,7 +35,8 @@ import Chart, { Slice } from 'src/types/Chart';
 import copyTextToClipboard from 'src/utils/copy';
 import { getClientErrorObject } from 'src/utils/getClientErrorObject';
 import SupersetText from 'src/utils/textUtils';
-import { FavoriteStatus, ImportResourceName, DatabaseObject } from './types';
+import { DatabaseObject } from 'src/features/databases/types';
+import { FavoriteStatus, ImportResourceName } from './types';
 
 interface ListViewResourceState<D extends object = any> {
   loading: boolean;
@@ -753,7 +754,9 @@ export function useDatabaseValidation() {
         .catch(e => {
           if (typeof e.json === 'function') {
             return e.json().then(({ errors = [] }: JsonObject) => {
-              if (database?.ssh_tunnel) {
+              if (database?.parameters?.ssh) {
+                // when ssh tunnel is enabled we don't want to render any validation errors
+                setValidationErrors([]);
                 return [];
               }
               const parsedErrors = errors