fix(plugin-chart-echarts): normalize temporal string groupbys (#24134)

apache · May 19, 2023 · f817c10 · f817c10
1 parent d0687d0
commit f817c10
Show file tree

Hide file tree

Showing 2 changed files with 199 additions and 187 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts b/superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
@@ -29,6 +29,7 @@ import {
   NumberFormatter,
   TimeFormatter,
   SupersetTheme,
+  normalizeTimestamp,
 } from '@superset-ui/core';
 import { SortSeriesType } from '@superset-ui/chart-controls';
 import { format, LegendComponentOption, SeriesOption } from 'echarts';
@@ -336,7 +337,12 @@ export function formatSeriesName(
     return name.toString();
   }
   if (name instanceof Date || coltype === GenericDataType.TEMPORAL) {
-    const d = name instanceof Date ? name : new Date(name);
+    const normalizedName =
+      typeof name === 'string' ? normalizeTimestamp(name) : name;
+    const d =
+      normalizedName instanceof Date
+        ? normalizedName
+        : new Date(normalizedName);
 
     return timeFormatter ? timeFormatter(d) : d.toISOString();
   }