Fix test

apache · Nov 1, 2021 · fb5db2e · fb5db2e
1 parent 0ec0b45
commit fb5db2e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -1682,7 +1682,7 @@ def before_update(
         target: "SqlaTable",
     ) -> None:
         """
-        Check whether before update if the target table already exists.
+        Check before update if the target table already exists.
 
         Note this listener is called when any fields are being updated and thus it is
         necessary to first check whether the reference table is being updated.

diff --git a/superset/examples/birth_names.py b/superset/examples/birth_names.py
@@ -130,7 +130,8 @@ def _set_table_metadata(datasource: SqlaTable, database: "Database") -> None:
 
     datasource.main_dttm_col = "ds"
     datasource.database = database
-    datasource.schema = schema
+    if schema:
+        datasource.schema = schema
     datasource.filter_select_enabled = True
     datasource.fetch_metadata()