Skip to content

Commit

Permalink
fix(cypress): prevent CI failure on codecov failure (#10892)
Browse files Browse the repository at this point in the history
  • Loading branch information
nytai authored Sep 15, 2020
1 parent 0129c42 commit fe9f614
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/bashlib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ cypress-run-all() {

# Upload code coverage separately so each page can have separate flags
# -c will clean existing coverage reports, -F means add flags
codecov -cF "cypress"
# || true to prevent CI failure on codecov upload
codecov -cF "cypress" || true

# After job is done, print out Flask log for debugging
say "::group::Flask log for default run"
Expand All @@ -205,7 +206,9 @@ cypress-run-all() {
local flaskProcessId=$!

cypress-run "sqllab/*" "Backend persist"
codecov -cF "cypress"

# || true to prevent CI failure on codecov upload
codecov -cF "cypress" || true

say "::group::Flask log for backend persist"
cat "$flasklog"
Expand Down

0 comments on commit fe9f614

Please sign in to comment.