Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request access form #1049

Closed
mistercrunch opened this issue Aug 31, 2016 · 2 comments
Closed

Request access form #1049

mistercrunch opened this issue Aug 31, 2016 · 2 comments
Labels
airbnb Airbnb related change:backend Requires changing the backend enhancement:request Enhancement request submitted by anyone from the community

Comments

@mistercrunch
Copy link
Member

When [Gamma] users do not have access to a dashboard / datasource, we currently redirect them to the welcome page and flash a message saying they don't have access.

Instead of that, we should redirect them to a place where they can request access. We can create a model and use the CRUD interface for this purpose. Fields needed for this new AccessRequest model are:

  • audit information (who/when) (use the mixin!)
  • dashboard(s), many to many relationship, ideally is pre-populated with where they came from
  • table(s), many to many relationship, ideally is pre-populated with where they came from, based on the dashboard

Admins should be able to see the list of requests and grant access easily from the list view

@xrmx
Copy link
Contributor

xrmx commented Aug 31, 2016

Can we make this optional under an option in settings please?

@mistercrunch mistercrunch added the enhancement:request Enhancement request submitted by anyone from the community label Aug 31, 2016
@bkyryliuk bkyryliuk self-assigned this Sep 6, 2016
@bkyryliuk bkyryliuk added airbnb Airbnb related change:backend Requires changing the backend labels Sep 6, 2016
@bkyryliuk bkyryliuk added this to the Fiji Sprint 2016-09-09 milestone Sep 6, 2016
@bkyryliuk
Copy link
Member

bkyryliuk commented Sep 22, 2016

Future works:

  • make it optional
  • maintain a system role for people who can grant rights
  • document the flows in the security section of the docs
  • a quick way to see the columns in the table (tooltip? link to endpoint that list the columns for a table?)
  • manage how granters could only grant permissions to a subset of dataset
  • request access to the databases, not only to the datasources
  • include free form message in the request form
  • offer to create a role if there are 0 roles granting access to the given datasource
  • email notifications
  • batch approval
  • store some metadata - dashboard / slide ids
  • better support for the dashboards - show the slices you have access to and allow to request access to others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airbnb Airbnb related change:backend Requires changing the backend enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

3 participants