[dashboard edit] No Switch to view mode option

[graceguo-supercat]

How to reproduce the bug

1. Go to Dashboard
2. Click on "Edit", dashboard will be in edit mode
3. Now I want to switch back to view mode without any change:

Expected results

Actual results

Click "DISCARD CHANGES" will reload page, it will take some time (if dashboard is large). And if user was in a tab, reload page will lost user's previous focused tab.

The old behavior is, if there is no change in the dashboard, we show "SWITCH TO VIEW MODE" button, and click button will only switch mode, no page reload.

I understand Colors button is confusing. But now we do not want the functionality to change dashboard color-scheme?

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Related to #10394

@mistercrunch

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.69. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[graceguo-supercat]

ping @mistercrunch @rusackas What do you think of setting color scheme function for dashboard? Do we just remove it?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[junlincc]

What do you think of setting color scheme function for dashboard?

do you mean, instead of setting it in the modal, have the setting on the dashboard?

[etr2460]

@graceguo-supercat could you reply to Junlin here? Thanks!

[graceguo-supercat]

Dashboard header controls are refactored. This is not an issue anymore.