style: use tabs in dashboard edit pane #10394
Conversation
|
@mistercrunch wondering if we should change order to charts>components>colors? Charts are the main element of a dashboard. |
|
I have not usage data to back this up, but for me I always "Save and add to dashboard" from explore and almost never use the chart panel in the "dashboard editor" |
mistercrunch
force-pushed
the
edit-dash-imp
branch
from
75fbbbb to
7e23f49
Compare
|
Never even noticed the "Colors" setting. Agreed this is weird. I use the Charts panel a lot. Sometimes you want to relayout the dashboard and it's easier to delete a chart first then re-add it later. Wondering if we can just keep the "Insert Components" panel as is and move "Set Color Scheme" to a modal triggered by a link in the dropdown menu?
Or we can change "Edit CSS" to "Change Appearance" and move color scheme selector to the Edit CSS modal. The same modal may even hold a "Select Theme" control in the future. |
mistercrunch
force-pushed
the
edit-dash-imp
branch
from
97fd830 to
7ecf231
Compare
| <span // eslint-disable-next-line react/no-danger | ||
| dangerouslySetInnerHTML={{ __html: datasourceLink }} | ||
| /> | ||
| <a href={datasourceUrl}>{datasourceName}</a> |
There was a problem hiding this comment.
Bycatch - moving away from dangerouslySetInnerHTML
|
@ktmud I did a lot of work to untangle the sliders and move towards tabs as defined in SIP-34 here, I'd hate to roll this back. |
|
Makes sense. I can see why it'd be useful to have the tabs. Here's another screenshot of SIP-34 design with proper tab titles and icons:
|
|
Oh I've been using Figma and I think something went wrong in the Sketch -> Figma transition in this area ... @Steejay ^^^ |
mistercrunch
force-pushed
the
edit-dash-imp
branch
2 times, most recently
from
a3bed12 to
1043aef
Compare
mistercrunch
force-pushed
the
edit-dash-imp
branch
from
1043aef to
ab9f2a3
Compare
* style: use tabs in dashboard edit pane * fix tests * more hackin' * getting ready to rip cell measurer * working * pogress * Fix cards * done * fix jest * fix cy
* style: use tabs in dashboard edit pane * fix tests * more hackin' * getting ready to rip cell measurer * working * pogress * Fix cards * done * fix jest * fix cy
mistercrunch
added
🏷️ bot
Currently the east pane in the "edit dashboard" flow is really confusing. The "Components" and "Colors" buttons at the top really act as tabs, and the "slider" pattern is kind of cool but confusing.
after (draft - general direction)
before