[table chart] raw records SELECT ALL option is broken

[graceguo-supercat]

Table chart's select all option is broken.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

lastest master branch

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[junlincc]

any idea which PR caused it? i dont recall anyone touched this area lately.

[zuzana-vej]

@junlincc it looks like this issue is still there. I think it could have been caused by earlier redesigns on the Explore page - similar as what caused #11379 or #11404 (just a guess, it's also ~2-3 weeks old issue, so discovered around the same time).

[junlincc]

on it. seems like @kgabryje touched this area recently?

[kgabryje]

@junlincc I don't think I did any changes to those Select buttons, but I'm on it!

[junlincc]

@junlincc I don't think I did any changes to those Select buttons, but I'm on it!

i dont think so either! then the next person who touched this area was Jesse maybe 😆 but thank you @kgabryje for the fix.🙏
tested, all good!

[kgabryje]

I looked through the changes and after all it was a regression caused by my PR from September - #10889. I refactored a for… of… loop to forEach in order to fix ESLint errors - however, there was a return statement inside. In the old version, it returned from the whole function and after refactor, it returned only from forEach, causing the outer function to keep running and finally breaking the result.