Chart Explore: Pasting text into Metrics fails and deletes other metrics

[zuzana-vej]

Pasting text into Metrics fails and deletes other metrics. This feature is commonly used if metrics are long - user finds them in documentation / from a colleague (via slack) / from previous chart - instead of typing the metric name user wants to paste it. This functionality worked at some point in the past.

Expected results

Existing metric remain, and newly pasted metric (if exists) also is in the Metrics field.

Actual results

Existing metrics disappear.

Screenshots

Step 1: There is some metric in the METRICS field.

Step 2: try to paste new metric, like "test_metric"

Step 3: All metrics disappear. Regardless of if metric that is being pasted exists or not.

How to reproduce the bug

1. Go to 'Chart Explore'
2. Click in 'Metrics field'
3. Paste name of a metric, for example try to paste 'test_metric'
4. See issue - all existing metrics disappear

Environment

(please complete the following information):

• superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.59. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[junlincc]

@zuzana-vej could you please provide a gif that shows the old behavior? do you think #11388 are caused by a same PR?

[zuzana-vej]

I can't provide video of old behavior (when pasting a metric into the box worked) because old behavior doesn't work right now (honestly I am not sure how long this has been broken, this might not be feature user uses every day, so it could be couple weeks).

I think they certainly touch the same component, so the regression is likely to be introduced when doing some redesign/changes to the Metrics box.

[kgabryje]

Can you assign me please?

[junlincc]

Can you assign me please?

added to Trello and assigned to you~

[junlincc]

tested~fixed. closing issue thanks! @kgabryje