Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Filters Custom SQL Where/Having dropdown never selecting #11411

Closed
3 tasks done
rwspielman opened this issue Oct 23, 2020 · 0 comments · Fixed by #11412
Closed
3 tasks done

Charts: Filters Custom SQL Where/Having dropdown never selecting #11411

rwspielman opened this issue Oct 23, 2020 · 0 comments · Fixed by #11412
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@rwspielman
Copy link
Contributor

When trying to set a custom SQL filter on a chart, selecting the dropdown and changing it renders the dropdown box useless. It never selects having or where when you click on it. Thus, it does not allow you to save the custom SQL query because its a required field

Expected results

Show the selected dropdown choice [where/having] and allow the user to save the custom sql filter

Actual results

custom SQL filter never is able to be saved if you try to change where/having

Screenshots

Screen Shot 2020-10-23 at 10 06 18 AM
Screen Shot 2020-10-23 at 10 07 51 AM

How to reproduce the bug

  1. Go to Chart
  2. Click on Filters
  3. Add a filter
  4. Click Custom SQL
  5. Change dropdown from where to having

Environment

(please complete the following information):

  • superset version: superset version 0.37.2
  • python version: python --version 3.6.9
  • node.js version: node -v 8.10.0
  • npm version: npm -v 3.5.2

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants