fix: multiple issues with FilterPopover #11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
fix_having
branch
from
87a9104 to
4f5cd4f
Compare
Codecov Report
@@ Coverage Diff @@
## master #11412 +/- ##
==========================================
+ Coverage 66.48% 66.65% +0.16%
==========================================
Files 859 861 +2
Lines 40853 40920 +67
Branches 3686 3693 +7
==========================================
+ Hits 27162 27276 +114
+ Misses 13590 13546 -44
+ Partials 101 98 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
changed the title
mistercrunch
commented
Oct 23, 2020
| @@ -178,21 +179,22 @@ export default class AdhocFilterEditPopover extends React.Component { | |||
| </Tab> | |||
| </Tabs> | |||
| <div> | |||
| <Button buttonSize="small" onClick={this.props.onClose} cta> | |||
There was a problem hiding this comment.
i18n, flip button (Save to the right and primary)
mistercrunch
commented
Oct 23, 2020
mistercrunch
force-pushed
the
fix_having
branch
from
106ede2 to
42e11a5
Compare
mistercrunch
commented
Oct 24, 2020
| @@ -87,7 +87,7 @@ describe('Annotations', () => { | |||
| .within(() => { | |||
| cy.get('input').type('y=1400000'); | |||
| }); | |||
| cy.get('button').contains('OK').click(); | |||
| cy.get('button').contains('OK').click({ force: true }); | |||
There was a problem hiding this comment.
bycatch, random cypress/CI failure
6 tasks
|
@kgabryje do you want to take it from here? Sounds like you know about some edges I did not encounter. |
|
@mistercrunch Beside the changes in |
mistercrunch
force-pushed
the
fix_having
branch
2 times, most recently
from
206fb75 to
dddcab0
Compare
mistercrunch
force-pushed
the
fix_having
branch
from
dddcab0 to
e4eb611
Compare
nytai
approved these changes
Oct 27, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix: Custom SQL in FilterPopover * Also fix apache#11394 * linting * fix tests
This was referenced Nov 26, 2023
This was referenced Dec 14, 2023
This was referenced Dec 20, 2023
mistercrunch
added
🏷️ bot
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
closes #11411, #11394
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
manually tested, tested both HAVING and WHERE, going back and forth