Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cross filter]cross-filtering scoping option should hide when x-filerting function is not enabled in Explore #16341

Closed
2 of 3 tasks
jinghua-qa opened this issue Aug 18, 2021 · 0 comments · Fixed by #16391
Closed
2 of 3 tasks
Assignees
Labels
#bug Bug report P3 Priority item - Normal preset:QA Preset QA team

Comments

@jinghua-qa
Copy link
Member

cross-filtering scoping option should hided when x-filerting function is not enabled in Explore

Expected results

when cross filter is not enable in explore, chart 3 dot menu will not show cross-filtering scoping option

Actual results

cross-filtering scoping option show when the chart is not enable for x-filtering

Screenshots

Screen Shot 2021-08-18 at 4 16 38 PM

How to reproduce the bug

  1. open a time-series chart in explore and do not select emit dashboard cross filter
  2. add chart to dashboard and open chart 3 dot menu
  3. See error

Environment

(please complete the following information):

  • superset version: latest master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jinghua-qa jinghua-qa added the #bug Bug report label Aug 18, 2021
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Aug 18, 2021
@jinghua-qa jinghua-qa changed the title [cross filter]cross-filtering scoping option should hided when x-filerting function is not enabled in Explore [cross filter]cross-filtering scoping option should hide when x-filerting function is not enabled in Explore Aug 18, 2021
@junlincc junlincc added the P3 Priority item - Normal label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report P3 Priority item - Normal preset:QA Preset QA team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants