Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show cross filter option only when cross filter is enabled #16391

Merged
merged 1 commit into from
Aug 24, 2021
Merged

fix: Show cross filter option only when cross filter is enabled #16391

merged 1 commit into from
Aug 24, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #16341

@junlincc @jinghua-qa @rusackas

AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-21.at.2.21.39.PM.mov

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 21, 2021 •
edited
Loading

Codecov Report

Merging #16391 (81a32a1) into master (3faf653) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16391      +/-   ##
==========================================
- Coverage   76.57%   76.56%   -0.01%     
==========================================
  Files        1000     1000              
  Lines       53489    53491       +2     
  Branches     6816     6818       +2     
==========================================
+ Hits        40957    40958       +1     
- Misses      12296    12297       +1     
  Partials      236      236
Flag Coverage Δ
javascript 70.88% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/components/SliceHeaderControls/index.tsx 75.00% <33.33%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3faf653...81a32a1. Read the comment docs.

@michael-s-molina
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://50.112.72.84:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

kgabryje
kgabryje reviewed Aug 22, 2021
View reviewed changes
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx Outdated
@@ -229,6 +230,7 @@ class SliceHeaderControls extends React.PureComponent<
value.behaviors?.includes(Behavior.INTERACTIVE_CHART),
)
.find(([key]) => key === slice.viz_type);
const emitCrossFilter = slice.form_data?.emit_filter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name it sth like canEmitCrossFilter? It might be mistaken for a function that emits a cross filter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Changed.

villebro
villebro approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I hadn't noticed this shortcoming 👍

@michael-s-molina michael-s-molina merged commit 575e7af into apache:master Aug 24, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@michael-s-molina
fix: Show cross filter option only when cross filter is enabled (apac…
972d9cd 
…he#16391)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@michael-s-molina
fix: Show cross filter option only when cross filter is enabled (apac…
603849e 
…he#16391)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje left review comments

@villebro villebro villebro approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cross filter]cross-filtering scoping option should hide when x-filerting function is not enabled in Explore
4 participants
@michael-s-molina @kgabryje @villebro @mistercrunch