Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach new report to the dashboard again, but there are no error messages on the page #18225

Closed
tenglong3158 opened this issue Jan 29, 2022 · 3 comments
Labels
#bug Bug report good first issue Good first issues for new contributors preset:cares Preset cares about this issue

Comments

@tenglong3158
Copy link

Attach new report to the dashboard again, but there are no error messages on the page.

How to reproduce the bug

  1. Select a dashboard with reports and open it;
  2. Then add a new report to the dashboard;
  3. At this point, a 409 error will be reported, but there is no prompt on the page.

Expected results

Error message displayed on the page

Actual results

a 409 error will be reported, but there is no prompt on the page.

Screenshots

image

Environment

(please complete the following information):

  • browser type and version: chrome 97.0.4692.99
  • superset version: 1.4.0 Source code deployment
  • python version: Python 3.8.12
  • node.js version: v14.15.5
  • any feature flags active: "ALERT_REPORTS": True,
@tenglong3158 tenglong3158 added the #bug Bug report label Jan 29, 2022
@tenglong3158
Copy link
Author

image
The value returned by this method 'getClientErrorObject' does not have the attribute 'message'.

From the screenshot below, you can see that the 'message' property of error is not assigned a value.

image

@geido geido added validation:required A committer should validate the issue good first issue Good first issues for new contributors preset:cares Preset cares about this issue labels Feb 1, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas rusackas removed the validation:required A committer should validate the issue label Jan 26, 2023
@stale stale bot removed the inactive Inactive for >= 30 days label Jan 26, 2023
@rusackas
Copy link
Member

@andrey-zayats took a look at this and was unable to reproduce the issue. I'm going to go ahead and remove the validation:required label and close the issue. If anyone sees this happening in Superset 2.0.x or later, or on master, we're open to revisiting this conversation, re-opening the ticket, or triaging a new Issue with updated context. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report good first issue Good first issues for new contributors preset:cares Preset cares about this issue
Projects
None yet
Development

No branches or pull requests

3 participants