Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart #19122

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 11, 2022

SUMMARY

Attach new report to the dashboard again, but there are no error messages on the page #18225

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
https://user-images.githubusercontent.com/47900232/158206908-7a8fe15e-31cf-4049-b7db-395d0755cecf.mov
Screen Shot 2022-03-14 at 11 37 26 AM

AFTER:
image

TESTING INSTRUCTIONS

How to reproduce the bug

  1. Create a report for a chart or dashboard from the top right settings menu "Alerts & Reports" section - make sure you create a Report and not an alert
  2. Go to the chart or dashboard that you created the report for
  3. Click the calendar icon to schedule a report

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…d report is added again into dashboard or chart
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #19122 (680bd06) into master (9ae51f7) will decrease coverage by 0.01%.
The diff coverage is 72.83%.

❗ Current head 680bd06 differs from pull request most recent head e3e341a. Consider uploading reports for the commit e3e341a to get more accurate results

@@            Coverage Diff             @@
##           master   #19122      +/-   ##
==========================================
- Coverage   66.63%   66.62%   -0.02%     
==========================================
  Files        1670     1671       +1     
  Lines       64570    64563       -7     
  Branches     6504     6506       +2     
==========================================
- Hits        43028    43014      -14     
- Misses      19858    19865       +7     
  Partials     1684     1684              
Flag Coverage Δ
javascript 51.33% <70.27%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/packages/superset-ui-core/src/style/index.tsx 100.00% <ø> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <ø> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <ø> (ø)
...n-chart-pivot-table/src/react-pivottable/Styles.js 0.00% <0.00%> (ø)
superset-frontend/src/GlobalStyles.tsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <ø> (ø)
superset-frontend/src/addSlice/App.tsx 0.00% <ø> (ø)
...end/src/components/Form/LabeledErrorBoundInput.tsx 100.00% <ø> (ø)
...frontend/src/dashboard/components/AddSliceCard.jsx 55.55% <ø> (ø)
superset-frontend/src/explore/App.jsx 0.00% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae51f7...e3e341a. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 21, 2022
@rusackas rusackas merged commit cb03570 into apache:master Mar 24, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
…d report is added again into dashboard or chart (#19122)

* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

* fix(export-add): make to setup the default error message

* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component

(cherry picked from commit cb03570)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…d report is added again into dashboard or chart (apache#19122)

* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

* fix(export-add): make to setup the default error message

* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants