Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] generally remove all code marked as "deprecated" (front end) #19015

Closed
rusackas opened this issue Mar 3, 2022 · 5 comments
Closed

[2.0] generally remove all code marked as "deprecated" (front end) #19015

rusackas opened this issue Mar 3, 2022 · 5 comments
Assignees

Comments

@rusackas
Copy link
Member

rusackas commented Mar 3, 2022

Look for comments stating that things that will be removed for, and remove them

@graceguo-supercat
Copy link

graceguo-supercat commented Mar 10, 2022

@eschutho and I went through superset-frontend code base and found 2 deprecation candidates:

But both of them are currently in use and no replacement code available. So we think it's not a right time to deprecate them right now.

@rusackas
Copy link
Member Author

Sweep through and change any comments like "will be deprecated in 2.0" to be "will be deprecated in a future version"

@rusackas
Copy link
Member Author

Consider removing Omnibar for 3.0 - @suddjian we should start 3.0 proposals board

@graceguo-supercat
Copy link

Given this discussion: #13305 (comment), we should consider remove this feature (now or 3.0)

@rusackas
Copy link
Member Author

I believe that since it was already marked as deprecated in the code, it's fair game to remove as part of this initiative. That work could be part of this Issue, or filed a separate one if need be, but I have no objection to the removal as part of 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants