Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(superset 2.0): remove front-end deprecated code #19241

Merged
merged 1 commit into from
Mar 18, 2022
Merged

chore(superset 2.0): remove front-end deprecated code #19241

merged 1 commit into from
Mar 18, 2022

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Mar 17, 2022 •
edited
Loading

SUMMARY

Remove deprecated front-end code for Superset 2.0 version.

Please see discussion here: #19015
Full Superset 2.0 details: https://github.com/orgs/apache/projects/32/views/1

cc @evans @suddjian

TESTING INSTRUCTIONS

CI and manual test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API: Omnibar

ktmud
ktmud approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the Omnibar feature (kind of) works now---thanks @geido for fixing it in #16273 . But I'd still vote to remove it as it's a subpar experience yet not critical to user experience. It also has trouble distinguish dashboards with the same names, making it less useful for large organizations:

image

@graceguo-supercat graceguo-supercat merged commit d41f9b2 into apache:master Mar 18, 2022
@villebro villebro added the v2.0 label Mar 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktmud ktmud ktmud approved these changes

@hughhhh hughhhh Awaiting requested review from hughhhh

@eschutho eschutho Awaiting requested review from eschutho

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@graceguo-supercat @ktmud @mistercrunch @villebro @michael-s-molina