-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'trino' not in table.dialect_options #21541
Comments
Note that we only encountered this error after upgrading the version of our UBI Python 3.9 image from 1-57 to 1-73: https://catalog.redhat.com/software/containers/ubi8/python-39/6065b24eb92fbda3a4c65d8f Reverting back to 1-57 fixes the issue. But we'd much rather be on the latest patched version of the image. |
Exact same issue, error, and stacktrace as above, but using apache/superset:latest image from Docker Hub for testing and development. |
We have same issue. We are using 1.5.0 docker image. Interestingly it gives this error with certain datasets. |
Seem like issue is related with sqlalchemy-trino. I've downgraded it to 0.4.1 from 0.5.0 and problem solved for me. |
@iercan My understanding is that the sqlalchemy-trino project is deprecated and was removed from Superset for that reason. You can see a note about that here, which also states that the project has been merged into the upstream Trino package itself: https://github.com/dungdm93/sqlalchemy-trino. Personally, I'd rather not re-introduce a deprecated dependency. |
You can install trino==0.315.0. Seems like latest version is problematic. |
@iercan Thanks for that info! I see that a duplicate issue has been raised here: trinodb/trino-python-client#237 |
just a heads up.. I just tried Superset v2.0.0 and the latest |
Using the latest release of Superset 2.0.0 with Trino 381 I can now load charts without this error. Previously I had this issue. I have explicitly tried Superset 2.0.0, Trino 381, and |
I was on 398 Trino, now 399.. with that pypi version of the Trino Library I
was not even able to connect to Trino in the GUI.. if I can I will try
again with 317 driver but for now backed off the 315... I get connected but
have now hit some sort of permissions issue possibly .. posted that to
Trino slack
…On Mon, Oct 10, 2022, 20:22 georgewfisher ***@***.***> wrote:
Using the latest release of Superset 2.0.0 with Trino 381 I can now load
charts without this error. Previously I had this issue.
I have explicitly tried Superset 2.0.0, Trino 381, and "trino":
["trino>=0.317.0"], and that combination works.
Trino Python library fix for this issue is here:
trinodb/trino-python-client#240
<trinodb/trino-python-client#240>
—
Reply to this email directly, view it on GitHub
<#21541 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4FJSQIYGAII344R62VVSLWCRNEPANCNFSM6AAAAAAQSHNJ7M>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Latest python client solved this issue. Trino 399 with python client 0.318 works without error now. FYI. |
I can confirm with trino 399 + hive-metastore 3.x + S3 + |
Are people still seeing this in Superset 3.0/3.1? This thread has been quiet for an awfully long time. |
Ok, hoping this is all resolved then. Please provide updated context if this needs to be reopened, or just open a fresh Issue :) |
A clear and concise description of what the bug is.
This seems related to #20043.
Our Superset/Trino integration has been broken by a recent update but I can't yet figure out a fix.
Our dashboards and graphs that utilize Trino are failing with
DB engine Error: 'TableClause' object has no attribute 'dialect_options'
.In the logs I'm also seeing
'trino' not in table.dialect_options
andWARNING:superset.db_engine_specs:Unable to load SQLAlchemy dialect <class 'es.opendistro.sqlalchemy.ESHTTPSDialect'>: No module named 'sqlalchemy_trino'
.We're on version 1.5.1 of Superset installed on a Python 3.9 Docker image via pip with extras, i.e.
pip install apache-superset[db2,druid,elasticsearch,mysql,postgres,thumbnails,trino]
.I see there has been a lot of activity lately around the Trino engine in this repo. I'm hoping someone with more intimate understanding of the SQLAlchemy dialect situation might be able to shed some light on what's going on, and how to fix it.
How to reproduce the bug
Expected results
Dashboard loads and can access Trino.
Actual results
Errors mentioned above (stack trace at bottom).
Screenshots
Environment
(please complete the following information):
1.5.1
3.9
N/A
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
The text was updated successfully, but these errors were encountered: