Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.1RC1: Clicking on "Time Range" in the Weekly Threads chart of the Slack Demo Dashboard results in a type error #21731

Closed
1 of 3 tasks
mattitoo opened this issue Oct 7, 2022 · 0 comments
Closed
1 of 3 tasks

2.0.1RC1: Clicking on "Time Range" in the Weekly Threads chart of the Slack Demo Dashboard results in a type error #21731

mattitoo opened this issue Oct 7, 2022 · 0 comments
Labels
#bug Bug report 🚢 2.1.3

Comments

@mattitoo
Copy link
Contributor

mattitoo commented Oct 7, 2022

A (hopefully) clear and concise description of what the bug is.

How to reproduce the bug

  1. Go to 'Slack Demo Dashboard'
  2. Click on 'Edit chart' for 'Weekly Threads'
  3. Click on 'Time Range' button
  4. See error (Unexpected error: TypeError: Cannot read properties of undefined (reading 'locale'))

Expected results

I can change the time range

Actual results

'Unexpected error'

Screenshots

Bildschirmfoto 2022-10-07 um 10 15 00

Environment

(please complete the following information):

  • browser type and version: Chrome Version 106.0.5249.103 (Offizieller Build) (x86_64)
  • superset version: 2.0.1RC1 docker version
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.
@mattitoo mattitoo added the #bug Bug report label Oct 7, 2022
eric-briscoe added a commit to preset-io/superset that referenced this issue Oct 11, 2022
@eric-briscoe
Resolves issue apache#21731 where date range in explore throws runtim…
aaaa34b 
…e error when explore.common is undefined in Redux state

Changes made in superset/superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx in PR https://github.com/apache/superset/pull/20063/files#diff-ac08ce133d14a8a92607bf02bc368b6b52b8314ddef1b872e42746ba8d6038d0

introduced bug that expects redux state to contain a path that is undefined
@eric-briscoe eric-briscoe mentioned this issue Oct 11, 2022
Merged
9 tasks
eschutho pushed a commit that referenced this issue Oct 13, 2022
@eric-briscoe
fix(CustomFrame): Resolves issue #21731 where date range in explore t…
2258fbf 
…hrows runtime error (#21776)
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this issue Nov 11, 2022
@eric-briscoe @Fahrenheit35
fix(CustomFrame): Resolves issue apache#21731 where date range in exp…
6bc3dba 
…lore throws runtime error (apache#21776)
AAfghahi pushed a commit that referenced this issue Nov 21, 2022
@eric-briscoe @AAfghahi
fix(CustomFrame): Resolves issue #21731 where date range in explore t…
c2f6256 
…hrows runtime error (#21776)
AAfghahi pushed a commit that referenced this issue Dec 15, 2022
@eric-briscoe @AAfghahi
fix(CustomFrame): Resolves issue #21731 where date range in explore t…
5677400 
…hrows runtime error (#21776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug Bug report 🚢 2.1.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mistercrunch @eschutho @mattitoo