Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blinking scrollbars (2.0.1) #22784

Closed
squalou opened this issue Jan 19, 2023 · 11 comments
Closed

Blinking scrollbars (2.0.1) #22784

squalou opened this issue Jan 19, 2023 · 11 comments
Assignees
Labels
preset:cares Preset cares about this issue

Comments

@squalou
Copy link
Contributor

squalou commented Jan 19, 2023

Screenshot

image

image

[drag & drop image(s) here!]

Description

Look at these two screenshots, imagine your browser switching from one to the other 4 times per seconds.

(I didn't manage to capture a video).

Resizing the screen doesn't change anything.

This is completely driving people mad :)

@squalou
Copy link
Contributor Author

squalou commented Jan 19, 2023

(happens with version 2.0.1)

1 similar comment
@squalou
Copy link
Contributor Author

squalou commented Jan 19, 2023

(happens with version 2.0.1)

@sfirke
Copy link
Member

sfirke commented Jan 19, 2023

Duplicate of #22393. Agreed it's not good.

@rusackas rusackas added preset:cares Preset cares about this issue v2.0.2 labels Jan 19, 2023
@rusackas
Copy link
Member

@AAfghahi Not sure if we can get internal resources to prioritize this, but it might be good to get a fix in for 2.0.2 if at all possible.

@svarcoe
Copy link

svarcoe commented Jan 19, 2023

We also are seeing this behavior. It only happens for tables in the Explorer view. The same chart inside a Dashboard does not have blinking scrollbars. Version 2.0.1.

@artemonsh
Copy link
Contributor

artemonsh commented Jan 23, 2023

I think it was solved here #20833
I am not sure though whether it was included in 2.0.1 or not

@squalou
Copy link
Contributor Author

squalou commented Jan 23, 2023

my 2 cents : I ran git blame -- superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx on sources tagged 2.0.1
and there's nothing more recent than 2022-05 (and nothing looking like the commit above), even if it's supposed to have landed in master.

@squalou
Copy link
Contributor Author

squalou commented Jan 24, 2023

I tested a local build with superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx from the mentioned pull request => looks good !

No idea why the commit was not included on master at some point.

@artemonsh
Copy link
Contributor

@squalou It was included on master but not on 2.0.1 release

@rusackas
Copy link
Member

rusackas commented Feb 9, 2023

Since this is fixed on master and slated for 2.0.2 per this thread, I think we can call this one done. Thanks @Antonio-RiveroMartnez for the fix!

@yousoph per the preset:cares tag, maybe it's worth confirming that any correlated issues we're concerned with are also resolved.

@sfirke
Copy link
Member

sfirke commented Feb 27, 2023

Alas I'm seeing the blinking/flashing scrollbars in 2.1.0rc1 with a Heatmap chart ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset:cares Preset cares about this issue
Projects
None yet
Development

No branches or pull requests

8 participants