Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp appears at end of x-axis for ECharts with long filtered interval #23197

Closed
sfirke opened this issue Feb 24, 2023 · 8 comments · Fixed by #24995
Closed

Timestamp appears at end of x-axis for ECharts with long filtered interval #23197

sfirke opened this issue Feb 24, 2023 · 8 comments · Fixed by #24995
Labels

Comments

@sfirke
Copy link
Member

sfirke commented Feb 24, 2023

This is a regression from 2.0.1, revealed when testing 2.1.0rc1 and also present on master branch as of 2023-03-22.

How to reproduce the bug

Create a time series Bar Chart v2, add to dashboard, set a filter to include time range from >1 year ago to now.

Expected results

Here's how this chart looks in 2.0.1 dashboard in production:
image

Actual results

Here is this chart in 2.1.0rc1 - note the timestamp value at the end of the x-axis, bottom-right of screenshot:
image

If I change the time grain to Week, the timestamp value changes:
image

If I put in 2022-12-01 as the start date, the timestamp goes away:
image

But it is present with 2022-11-01 as the start date.

Environment

(please complete the following information):

  • browser type and version: Firefox
  • superset version: 2.1.0rc1 and latest as of March 22 2023
  • any feature flags active: GENERIC_CHART_AXES

The only maybe-relevant thing I see in the logs is DEBUG:parsedatetime:eval now with context - False, False

Edit: I also see it on the 2nd chart in this issue #23453 (comment).

@sfirke sfirke added the #bug Bug report label Feb 24, 2023
@sfirke
Copy link
Member Author

sfirke commented Mar 14, 2023

This persists in 2.1.0rc2. I see it also affects line charts:
image

@D3nn3
Copy link

D3nn3 commented Apr 12, 2023

Can confirm with the final v2.1.0 release, even without the GENERIC_CHART_AXES feature flag enabled.

@rusackas rusackas added the v2.1 label Apr 12, 2023
@LahmerIlyas
Copy link
Contributor

I will start working on this. If anyone else is working on this, please let me know to avoid any conflicts.

@sfirke sfirke changed the title Timestamp appears at end of x-axis for Bar Chart v2 with long filtered interval Timestamp appears at end of x-axis for ECharts with long filtered interval Apr 26, 2023
@yousoph
Copy link
Member

yousoph commented Jun 23, 2023

Some related discussion here: #20627 (comment)

The original fix was to address an issue where the last month wasn't displaying on the x-axis:
image

@eschutho
Copy link
Member

@sfirke what do you think about us reverting #20627 (comment) for 2.1.1 while we wait for a fix?

@sfirke
Copy link
Member Author

sfirke commented Jul 20, 2023

@eschutho yes my two cents is that the prior behavior of omitting the latest month's label is better than the current behavior. A revert for 2.1.1 sounds like an improvement to me.

Would it also make sense to include the revert in 3.0.0rc2?

@mpostelnicu
Copy link

i too think it should be reverted for 2.1.1 until a better solution is found. This makes all yearly charts present with an artifact at the end of the axis.

@sfirke
Copy link
Member Author

sfirke commented Aug 18, 2023

Can confirm that the reversion fixed this in 2.1.1rc3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants