-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627) #24995
Merged
john-bodley
merged 2 commits into
apache:master
from
preset-io:elizabeth/revert-timestamp-axis
Aug 16, 2023
Merged
fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627) #24995
john-bodley
merged 2 commits into
apache:master
from
preset-io:elizabeth/revert-timestamp-axis
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is (apache#20627)" This reverts commit 9362e27.
Antonio-RiveroMartnez
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after ci is fixed
eschutho
changed the title
Revert "fix(chart): Time Series set showMaxLabel as null for time xAx…
fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAx…
Aug 16, 2023
michael-s-molina
added
the
v3.0
Label added by the release manager to track PRs to be included in the 3.0 branch
label
Aug 16, 2023
michael-s-molina
changed the title
fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAx…
fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627)
Aug 16, 2023
villebro
approved these changes
Aug 16, 2023
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 16, 2023
…e xAxis (apache#20627) (apache#24995) (cherry picked from commit 2b63577)
eschutho
added a commit
that referenced
this pull request
Aug 17, 2023
eschutho
added a commit
that referenced
this pull request
Aug 18, 2023
mpostelnicu
pushed a commit
to devgateway/ocmoldova-superset
that referenced
this pull request
Aug 31, 2023
…e xAxis (apache#20627) (apache#24995) (cherry picked from commit 2b63577)
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9362e27.
From #20627
To address a regression #23197
We'll work on a different fix forward for the missing x axis label bug.
Fixes #23197
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION