Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627) #24995

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Aug 15, 2023

This reverts commit 9362e27.
From #20627
To address a regression #23197
We'll work on a different fix forward for the missing x axis label bug.

Fixes #23197

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after ci is fixed

@eschutho eschutho changed the title Revert "fix(chart): Time Series set showMaxLabel as null for time xAx… fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAx… Aug 16, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 16, 2023
@michael-s-molina michael-s-molina changed the title fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAx… fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627) Aug 16, 2023
@john-bodley john-bodley merged commit 2b63577 into apache:master Aug 16, 2023
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 16, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 17, 2023
mpostelnicu pushed a commit to devgateway/ocmoldova-superset that referenced this pull request Aug 31, 2023
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 size/S v2.1 v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp appears at end of x-axis for ECharts with long filtered interval
5 participants