Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ocient): convert GIS data types to geoJSON for the Ocient engine #23907

Closed
3 tasks done
jwilliams-ocient opened this issue May 2, 2023 · 1 comment
Closed
3 tasks done
Labels
#bug Bug report

Comments

@jwilliams-ocient
Copy link
Contributor

jwilliams-ocient commented May 2, 2023

The Ocient engine currently emits GIS objects that are incompatible with any of the deck.gl visualization charts. The existing implementation attempts to emit coordinate arrays which are invalid for polygons with holes and a few other edge cases.

The Ocient engine should emit geoJSON for all geospatial types.

Ocient alse has a... unique way of encoding geometry collections that results in Point or LineString objects being encoded as Polygons. Obviously, a geoJSON polygon containing a single point in its exterior ring produces invalid geoJSON,

See: #23814

How to reproduce the bug

  1. Execute any query emitting a polygon object using SQL Lab
  2. Create a dataset from the query in (1)
  3. Create any deck.gl chart

Expected results

N/A

Actual results

N/A

Screenshots

N/A

Environment

All environments

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jwilliams-ocient jwilliams-ocient added the #bug Bug report label May 2, 2023
@rusackas
Copy link
Member

I'd love to support this, but I'm not sure how. Is it something you'd be willing to propose/submit a fix for?

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. We can re-open this if you think it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants