fix(ocient): convert pyocient GIS data types to geoJSON #23814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23814 +/- ##
==========================================
- Coverage 68.31% 68.29% -0.02%
==========================================
Files 1951 1951
Lines 75385 75401 +16
Branches 8185 8185
==========================================
+ Hits 51496 51498 +2
- Misses 21786 21800 +14
Partials 2103 2103
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The previous implementation did not emit a Deck.gl-compatible GIS types correctly in all cases. Now, the Ocient engine will always return geoJSON for geospatial types, including types that are upcasted and placed into type-safe GIS containers (i.e. a Polygon[] geo collection that contains point and linestring objects).
jwilliams-ocient
force-pushed
the
user/jwilliams/ocient-geospatial-cleanup
branch
from
736b627
to
287bba1
Compare
jwilliams-ocient
changed the title
jwilliams-ocient
changed the title
daveboutcher
approved these changes
Apr 27, 2023
|
Closing and reopening to kick off new CI run |
|
There's a CSV test broken on the master branch. Once the fix has been merged I will close/reopen |
3 tasks
rusackas
approved these changes
May 11, 2023
There was a problem hiding this comment.
LGTM, but would love to get some additional eyes on this, so pinging @villebro @john-bodley @michael-s-molina for extra 👀
villebro
approved these changes
May 17, 2023
…ms/ocient-geospatial-cleanup
|
Thank YOU! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR addresses a bug that sometimes causes the Ocient engine to emit invalid polygon and linestring objects. See commit messages for more info.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION