Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard export issue #2667

Closed
xyhc opened this issue Apr 24, 2017 · 8 comments
Closed

dashboard export issue #2667

xyhc opened this issue Apr 24, 2017 · 8 comments
Labels
inactive Inactive for >= 30 days

Comments

@xyhc
Copy link

xyhc commented Apr 24, 2017 •
edited by xrmx
Loading

Sorry, something went wrong

500 - Internal Server Error

Stacktrace

Traceback (most recent call last):
  File "/usr/local/python27/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/python27/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/python27/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/python27/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/python27/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/python27/lib/python2.7/site-packages/flask_appbuilder/views.py", line 533, in action
    return action.func(self.datamodel.get(pk))
  File "/usr/local/python27/lib/python2.7/site-packages/superset/views.py", line 957, in mulexport
    ids = ''.join('&id={}'.format(d.id) for d in items)
TypeError: 'Dashboard' object is not iterable
@xrmx
Copy link
Contributor

xrmx commented Apr 24, 2017

Which version of superset?

@xyhc
Copy link
Author

xyhc commented Apr 24, 2017

0.15.1

@xrmx
Copy link
Contributor

xrmx commented Apr 24, 2017

Please reproduce with latest version

@xyhc
Copy link
Author

xyhc commented Apr 24, 2017

I try it , thanks!

@xyhc
Copy link
Author

xyhc commented Apr 24, 2017

I upgrade the superset to 0.17.5 , but the issue is the same as before.

@eeve eeve mentioned this issue May 15, 2017
Merged
mistercrunch pushed a commit that referenced this issue May 16, 2017
@eeve @mistercrunch
fixed 500 error when export dashboard (#2760)
e794645 
https://github.com/airbnb/superset/blob/master/superset/views/core.py#L474

http://flask-appbuilder.readthedocs.io/en/latest/actions.html?highlight=action

```
@action("mulexport", __("Export"), __("Export dashboards?"), "fa-database")
    def mulexport(self, items):
        ids = ''.join('&id={}'.format(d.id) for d in items)
```
change to 
```
@action("mulexport", __("Export"), __("Export dashboards?"), "fa-database")
    def mulexport(self, items):
        if not isinstance(items, list):
            items = [items]
        ids = ''.join('&id={}'.format(d.id) for d in items)
```

fixed:
#2184
#2667
@XavierDeLapeyre
Copy link

Hi all

I am on 0.21.x ( 0.21.0Dev and 0.21.1 )
Where can I find the export Dashboard feature? ( I don't see it anywhere, found the import Dashboard though )

@mistercrunch
Copy link
Member

screen shot 2017-12-13 at 9 26 56 pm

@stale
Copy link

stale bot commented Apr 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 11, 2019
@stale stale bot closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inactive Inactive for >= 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xrmx @mistercrunch @XavierDeLapeyre @xyhc