-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install superset-frontend dependencies by using node v20.11.1 and yarn v1.22.22 #28094
Comments
Recommended node is 18 at this time. Are you trying to to wrap superset into something else? There are subpackage where you can do some of that here https://github.com/apache/superset/tree/master/superset-frontend/packages, but it's not common or recommended to install the whole app as a dependency |
@mistercrunch, yeah, I researched how to integate and use new versions of the I tried to install them pointwise via a modified bash-script. But that way was ended unsuccessfully. And as I remember, the errors linked to In the end, I decided to try to add But also I met with installation problem. But, as I checked, node v20 works correctly as v18. And it installs only with warnings if I install the module separately (without using yarn workspaces). And I thought: "why not to add a range of node' versions?" P.S. And, sure, I wouldn't set the whole |
@mistercrunch, thanks a lot for your comment! While I described my problem above, I got a new alternative idea about how to try to work with the @superset-ui/core, @superset-ui/chart-controls and @superset-ui/plugin-chart-echarts |
It'd be really great if these packages can be self-standing, that's the vision for sure, in practice may be tricky with all the webpack/babel/frontend-infra stuff. I know in the past it was super difficult to work on visualization or components without having it as a mono-repo. Let us know how it goes, and anything you can do to make it easier for the next person is well appreciated. |
Bug description
Introduction
I use node v20.11.1 and yarn v1.22.22 for my project. And represented the superset-frontend directory as a workspace module, by using a custom bash script (which called on the preinstall step):
clone-subdir.sh
package.json
Problem
It works fine. But the problem happens on the installation step. I got the next error log at the installation of the superset-frontend dependencies:
Solution
The reason why it happens is the concrete node's version which is set at the
engine
's field. It will be better to replace the current value with a logical expression like:"node": ">= 18"
. It will save backward compatibility with the v18 and allow to work with the frontend part by using newer versions.How to reproduce the bug
"private": true
field)preinstall
scriptyarn install
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
Not applicable
Node version
18 or greater
Browser
Not applicable
Additional context
No response
Checklist
The text was updated successfully, but these errors were encountered: