fix(superset-frontend): resolve installation step problem by using node > 18 #28095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corocoto
changed the title
john-bodley
reviewed
Apr 17, 2024
| @@ -353,7 +353,7 @@ | |||
| "xdm": "^3.4.0" | |||
| }, | |||
| "engines": { | |||
| "node": "^18.19.1", | |||
| "node": ">= 18", | |||
There was a problem hiding this comment.
Should there maybe be an upper bound and/or have a mechanism to exclude odd (non-even) versions?
There was a problem hiding this comment.
@john-bodley, we can set the range of available versions. As example:
{
"engines": {
"node": ">=18 <21"
}
}NB. For more info you can read the section about engines field from the official npm docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Sets a logical expression
"node": ">= 18"at theenginesfield. It will save backward compatibility with the v18 and allow to work with the frontend part by using newer versions.ADDITIONAL INFORMATION
Fixes #28094