Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downgraded dependency react-alert #3588

Closed
dennybiasiolli opened this issue Oct 4, 2017 · 0 comments · Fixed by #3596
Closed

downgraded dependency react-alert #3588

dennybiasiolli opened this issue Oct 4, 2017 · 0 comments · Fixed by #3596

Comments

@dennybiasiolli
Copy link
Contributor

react-alert was updated to v2.0.1 in commit 7c28e4e, but was downgraded to v1.0.14 in commit 7045018, is there a reason for the downgrade or I can make a new PR updating to latest version? (cc @mistercrunch)
As I said in #2923 the old version of react-alert used React.PropTypes and it was deprecated. The new version is compatible with React 15+.
dennybiasiolli added a commit to dennybiasiolli/superset that referenced this issue Oct 4, 2017
@dennybiasiolli
updating react-alert dependency to v2.3.0
8f50eae 
it was downgraded in commit 7045018.
The old version used React.PropTypes and it was deprecated.
This version is compatible with React 15+.

Fix apache#3588
@dennybiasiolli dennybiasiolli mentioned this issue Oct 4, 2017
Merged
mistercrunch pushed a commit that referenced this issue Oct 4, 2017
@dennybiasiolli @mistercrunch
updating react-alert dependency to v2.3.0 (#3596)
ff268a7 
it was downgraded in commit 7045018.
The old version used React.PropTypes and it was deprecated.
This version is compatible with React 15+.

Fix #3588
michellethomas pushed a commit to michellethomas/panoramix that referenced this issue May 24, 2018
@dennybiasiolli @michellethomas
updating react-alert dependency to v2.3.0 (apache#3596)
f75934c 
it was downgraded in commit 7045018.
The old version used React.PropTypes and it was deprecated.
This version is compatible with React 15+.

Fix apache#3588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updating react-alert dependency to v2.3.0 dennybiasiolli/superset
1 participant
@dennybiasiolli