Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolling list (SQL Lab Query Search) #7526

Closed
3 tasks done
tomdewildt opened this issue May 16, 2019 · 4 comments
Closed
3 tasks done

Fix scrolling list (SQL Lab Query Search) #7526

tomdewildt opened this issue May 16, 2019 · 4 comments
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@tomdewildt
Copy link

tomdewildt commented May 16, 2019 •
edited
Loading

When the content in the Query Search table is larger than the viewport no scrollbar appears. Leaving the user unable to scroll.

Expected results

A scrollbar appears and the user is able to scroll.

Actual results

No scrollbar appears and the user is unable to scroll.

Screenshots

superset-sqllab-query-search-no-scrollbar

How to reproduce the bug

  1. Create 15 or more querries.
  2. Visit the Query Search page.

Environment

  • superset version: master
  • python version: 3.6.7
  • node.js version: v9.11.2
  • npm version: 5.6.0

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label May 16, 2019
@margrathea
Copy link

If you add overflow: auto to the scrollbar-container div in your browser than you're able to scroll again...

@protok
Copy link

protok commented May 17, 2019

If you add overflow: auto to the scrollbar-container div in your browser than you're able to scroll again...

This is just a quick hack, this needs to be fixed somewhere in the stylesheets.

@tomdewildt
Copy link
Author

tomdewildt commented May 17, 2019 •
edited
Loading

If you add overflow: auto to the scrollbar-container div in your browser than you're able to scroll again...

This breaks other UI elements that also use the .scrollbar-container class

@tomdewildt tomdewildt changed the title Unable to scroll when table content is larger than the viewport Fix scrolling list (SQL Lab Query Search) May 22, 2019
rusackas added a commit to preset-io/superset that referenced this issue Jun 7, 2019
@rusackas
Fixed SQL Lab Query Search scrolling issue(apache#7526)
ab1f3e4
mistercrunch pushed a commit that referenced this issue Jun 9, 2019
@rusackas @mistercrunch
Fixed SQL Lab Query Search scrolling issue(#7526) (#7674)
514c308
etr2460 pushed a commit to airbnb/superset-fork that referenced this issue Jul 11, 2019
@rusackas
Fixed SQL Lab Query Search scrolling issue(apache#7526) (apache#7674)
0d66775
etr2460 pushed a commit to airbnb/superset-fork that referenced this issue Jul 11, 2019
Merge pull request #137 from airbnb/erik-ritter--query-search-scroll
09dd3c3 
Fixed SQL Lab Query Search scrolling issue(apache#7526) (apache#7674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@protok @tomdewildt @margrathea