Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate tslint in favor of eslint w/ typescript support #8865

Closed
nytai opened this issue Dec 18, 2019 · 5 comments · Fixed by #9172
Closed

deprecate tslint in favor of eslint w/ typescript support #8865

nytai opened this issue Dec 18, 2019 · 5 comments · Fixed by #9172
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@nytai
Copy link
Member

nytai commented Dec 18, 2019

Having recently written some typescript in the repo I found the tslint rules to be very strict. Rules like alphabetizing object keys, not allowing lambdas in jsx, not allowing multiline expressions in jsx, among others don't coincide with the eslint rules and are not autofixable. Spending time fixing these is tedious and does not encourage use of typescript.

In order to increase adoption of typescript in the repo I think it would be good to have the typescript developer experience to be as closer to the current javascript experience. Also, it looks like the creators of tslint are recommending not using that library anymore.

We should configure eslint to support typescript and try to have as many of the same rules in both environments as possible. Info on how to implement this: https://codeburst.io/from-eslint-to-tslint-and-back-again-bf259c2e7437

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.87. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the enhancement:request Enhancement request submitted by anyone from the community label Dec 18, 2019
@nytai
Copy link
Member Author

nytai commented Dec 18, 2019

🏷 frontend

@etr2460
Copy link
Member

etr2460 commented Dec 20, 2019

cc @williaster and @kristw for their opinions.

Also, have you considered looking into the build configs in the superset-ui-plugins and superset-ui repos and seeing if they make sense here?

@kristw
Copy link
Contributor

kristw commented Feb 7, 2020

Those repositories use eslint with typescript support.

@williaster
Copy link
Contributor

standardizing on the nimbus build configs from superset-ui + superset-ui-plugins repos seems like it could be a good idea. then it's one thing to learn across all repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants