[SIP-36] deprecate tslint and configure eslint for typescript #9172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR deprecates tslint and configures eslint for typescript files. Using
@airbnb/nimbus
would be preferable as a long term goal, however that library is poorly documented and I had trouble getting it to work with our current setup. I left the WIP on a branch https://github.com/preset-io/incubator-superset/tree/tai/eslint-ts if anyone more familiar with integratin nimbus into existing projects would like to pick it up. For now this gets rid of tslint (and it's overly strict rules) which should make it easier to transition to typescript.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@etr2460 @suddjian @rusackas