Cursor falls behind in SQL Lab

[etr2460]

When typing in SQL Lab, the cursor slowly falls behind the characters.

Expected results

Typing to be normal

Actual results

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

Type a longish line in SQL Lab

Environment

(please complete the following information):

• superset version: master
• browser: latest Chrome

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

I suspect this is related to the change that was made to fix cursor position in Safari. I then think the issue was exacerbated by the new font in SQL Lab. This seems likely as we saw a report from a user that the cursor was messed up in Chrome prior to rolling out the new fonts, but with the new font it's way more obvious and happens way more often

cc: @rusackas @nytai

[rusackas]

Awww man! I agree with your assessment, but don't yet know the root cause. Investigating...

[willbarrett]

@rusackas I think you pushed a fix for this?

[etr2460]

@willbarrett I sent a chat to Evan, I think this is likely caused by his first fix :(

[willbarrett]

Oh no! 😢

[rusackas]

Submitted a PR reverting that earlier fix. Seems to work in both browsers now that the new font is in. Sunk some time last night into trying to upgrade ACE editor (which also fixes this), but that started getting too hairy, so I pulled the ripcord on that. Please sanity check that PR and make sure the issue is really gone :)

[mapshen]

Hi all, we are running apache/superset:257385e888c5f9530882c62a20981bfd00e83009 which is a build pushed a few days ago in docker and we now are experiencing the same issue as @etr2460 described. Would any of you be able to take a look?

[mapshen]

I just tested with the latest build with docker pull apache/superset:66c28d653f3f9381479ab817e6dba8f6598d8b8d and can confirm the issue is there.

@rusackas Would you have time to take a look? Thanks!

[junlincc]

@geido users reported this is happening again. We fixed the editor in Explore, but im not able to reproduce in SQL lab. could you take a look?

[ayushbilala]

I am on Superset 1.3.2 and able to replicate the issue on Windows OS.
Font style is very different and clean in Mac though. Can we please expect a fix for this?

[shreyaUp]

I am on Superset 1.3.2 and able to replicate the issue on Windows OS. Font style is very different and clean in Mac though. Can we please expect a fix for this?

Same here. A fix would really help!

[geido]

I can't reproduce. Pinging some more people to see if this can be reproduced on their side CC @kgabryje @zhaoyongjie @michael-s-molina

[shumway743]

We are also experiencing this with the latest release. The issue seems to be related to syntax highlighting. If you type "select select select ..." all the way across the screen you will see the cursor lag (select is bolded as it is a keyword). If you type a non-keyword such as "hello hello hello ..." across the window, the cursor seems to keep up fine (no bolding takes place). Just an observation.

[LuPan2015]

@geido @junlincc I had the same problem with superset 1.4.0. Details are as follows:

SELECT
    database,
    table,
    partition,
    sum(rows) AS rows,
    count() AS part_count
FROM system.parts
WHERE (active = 1) AND (table ='game_match_log') AND (database ='gem') and partition =  ''
GROUP BY
    database,
    table,
    partition
ORDER BY part_count DESC;
limit 30;

20220617_120648.mp4

[ubyyj]

same issue here, 1.4.0 in Chrome

[drummerwolli]

Issue seems to be still prominent, especially on Windows machines, on 2.0.0 ...

[MichaelHintz]

For me, opening the developer tools and disabling font-family: Menlo,Lucida Console,Courier New,Ubuntu Mono,Consolas,source-code-pro,monospace or at least removing Lucida Console is fixing the issue, as described in:

#19094 (comment)
#9183 (comment)
#15749 (comment)

The problem seems to be that Lucida Console doesn't have a bold version on Windows, so Windows tries to make it bold by making it wider.

[1] wez/wezterm#2074

[2] https://forums.allroundautomations.com/ubb/ubbthreads.php?ubb=showflat&Number=29702#:~:text=issue%20with%20in%20the%20font

[3] https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list#:~:text=5.05-,Lucida%20Console,-Lucida%20Console

Consolas and Courier New both come with bold versions on windows. Any chance Consolas can be moved

superset/superset-frontend/src/SqlLab/main.less

Lines 370 to 371 in ce3d38d

	font-family: 'Menlo', 'Lucida Console', 'Courier New', 'Ubuntu Mono',
	'Consolas', 'source-code-pro', monospace;

before Lucida Console?

Another 'fix' that I can confirm is uninstalling Lucida Console from Windows.

All related issues and PRs I could find:
#9253
#15749
#19094
#19580
#20436

#9183
#9264
#12423